Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce storage factory and speed up api startup by importing storage client on demand #9086

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Oct 8, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • introduce enum class StorageTypeof storage type values
  • introduce storage factory
  • import storage client libraries on demand , speeding up API startup time
  • replace lagacy uage of app.config into dify_config's direct config entry reference

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 8, 2024
@bowenliang123 bowenliang123 changed the title choreget_storage_factory chore: speed up api startup time by importing storage client on demand Oct 8, 2024
@bowenliang123 bowenliang123 changed the title chore: speed up api startup time by importing storage client on demand refactor: speed up api startup time by importing storage client on demand Oct 8, 2024
@bowenliang123
Copy link
Contributor Author

cc @crazywoola @laipz8200

laipz8200
laipz8200 previously approved these changes Oct 8, 2024
Copy link
Collaborator

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
@bowenliang123 bowenliang123 changed the title refactor: speed up api startup time by importing storage client on demand refactor: introduce storage factory and speed up api startup by importing storage client on demand Oct 8, 2024
@bowenliang123 bowenliang123 force-pushed the improve-store-ext branch 2 times, most recently from 6bdf2c7 to 9fc415f Compare October 9, 2024 00:43
@crazywoola crazywoola merged commit b360feb into langgenius:main Oct 9, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the improve-store-ext branch October 9, 2024 06:26
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants