-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable chat service API passing parent_message_id
#8984
Merged
laipz8200
merged 10 commits into
langgenius:main
from
xuzuodong:feat/chat-api-regenerate
Oct 14, 2024
Merged
feat: disable chat service API passing parent_message_id
#8984
laipz8200
merged 10 commits into
langgenius:main
from
xuzuodong:feat/chat-api-regenerate
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Oct 2, 2024
xuzuodong
changed the title
Chatting via service API force
Chat via service API forcing parent_message_id to be UUID_NIL
Oct 2, 2024
UUID_NIL
as parent_message_id
crazywoola
force-pushed
the
feat/chat-api-regenerate
branch
from
October 3, 2024 02:24
8f8958f
to
53d6d3a
Compare
5 tasks
laipz8200
reviewed
Oct 11, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Oct 12, 2024
xuzuodong
changed the title
Chat via service API forcing parent_message_id to be UUID_NIL
chore: disable chat service API passing Oct 12, 2024
parent_message_id
laipz8200
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you :)
laipz8200
changed the title
chore: disable chat service API passing
feat: disable chat service API passing Oct 21, 2024
parent_message_id
parent_message_id
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
@laipz8200 @xuzuodong How to achieve 'regeneration' of historical information if this parameter is lost? How can I use the API to modify historical conversation messages without this parameter? @AllenWriter all |
5 tasks
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplementation of #8965, fixes #8910, but using a better way to be compatible.
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration