Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: massive update of the Gemini models based on latest documentation #8822

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

CXwudi
Copy link
Contributor

@CXwudi CXwudi commented Sep 27, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (no code changes)
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods (no code changes)

Description

Fixes #8821.

Also, based on the documentation, "Latest" and "Latest Stable" models are two different versions. Hence, I also separated the gemini-1.5-pro away from gemini-1.5-pro-latest. Likewise for flash models.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test several new models in various scenarios, such as Agent + Function calling, Workflow, etc.

Screenshot 2024-09-26 120133
Screenshot 2024-09-26 122123
Screenshot 2024-09-26 122248
Screenshot 2024-09-26 125204

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 27, 2024
@CXwudi CXwudi changed the title Massive update the Gemini models based on latest documentation chore: massive update of the Gemini models based on latest documentation Sep 27, 2024
crazywoola
crazywoola previously approved these changes Sep 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@crazywoola crazywoola self-requested a review September 27, 2024 00:59
@crazywoola
Copy link
Member

Hello can you take a look at this feature as well? #8805

@CXwudi
Copy link
Contributor Author

CXwudi commented Sep 27, 2024

Hello can you take a look at this feature as well? #8805

Hi, I could try, but I am not familiar with Dify codebase, so please don't bet on me.

@crazywoola crazywoola merged commit e5efd09 into langgenius:main Sep 27, 2024
6 checks passed
@CXwudi CXwudi deleted the chore/add-more-gemini-models branch September 27, 2024 01:17
@CXwudi
Copy link
Contributor Author

CXwudi commented Sep 27, 2024

@crazywoola About the request of #8805, are you referring to #8721 which simply just remove the harm category setting, but this time you want me to do it for Gemini endpoints?

If that so, I believe that is simply just removing:

https://github.com/langgenius/dify/blob/main/api/core/model_runtime/model_providers/google/llm/llm.py#L209-L214

Correct? If so, then I think I can do that

cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added newest Gemini models
2 participants