Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Jina embedding model #8376

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

DresAaron
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@DresAaron DresAaron marked this pull request as ready for review September 13, 2024 11:42
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 13, 2024
@DresAaron DresAaron marked this pull request as draft September 13, 2024 11:54
@DresAaron DresAaron marked this pull request as ready for review September 13, 2024 12:23
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 14, 2024
@crazywoola crazywoola merged commit 6f7625f into langgenius:main Sep 14, 2024
6 checks passed
@langgenius langgenius deleted a comment from rosehuynh92 Sep 14, 2024
LLmoskk pushed a commit to LLmoskk/dify that referenced this pull request Sep 16, 2024
hos715 pushed a commit to hos715/dify that referenced this pull request Sep 16, 2024
hos715 pushed a commit to hos715/dify that referenced this pull request Sep 16, 2024
laipz8200 pushed a commit that referenced this pull request Sep 18, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants