Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable typo (cont) #8161

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

ZuzooVn
Copy link
Contributor

@ZuzooVn ZuzooVn commented Sep 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix variable typo (cont)

Type of Change

  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2024
@crazywoola crazywoola merged commit 0695543 into langgenius:main Sep 9, 2024
6 checks passed
@ZuzooVn ZuzooVn deleted the fix-variable-typo-(cont) branch September 9, 2024 17:29
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Sep 10, 2024
* commit 'dabfd74622a613c7198f06791ad70424ac94f54f': (222 commits)
  feat: Parallel Execution of Nodes in Workflows (langgenius#8192)
  docs: replace docker-compose with docker compose (langgenius#8195)
  refactor(api/core): Improve type hints and apply ruff formatter in agent runner and model manager. (langgenius#8166)
  filter excel empty sheet (langgenius#8194)
  fix: The length of the tag should between 1 and 50 (langgenius#8187) (langgenius#8188)
  nvidia rerank top n missed (langgenius#8185)
  fix: Version '2.6.2-2' for 'expat' was not found (langgenius#8182)
  code merge error (langgenius#8183)
  add volcengine tos storage (langgenius#8164)
  chore: bump super-linter to v7 (langgenius#8148)
  feat(api/core/model_runtime/entities/defaults.py): Add TOP_K in default parameters. (langgenius#8167)
  Fix variable typo (cont) (langgenius#8161)
  update qwen-long (langgenius#8157)
  Update LICENSE - remove 'SaaS' from restriction term definition (langgenius#8143)
  fix: html raw render (langgenius#8138)
  chore: translate i18n files (langgenius#8135)
  fix: user-select style and pre-create iframe in embed.js (langgenius#8093)
  Modify model parameters in Spark LLMs and zhipuai LLMs (langgenius#8078)
  chore: offline n to 1 retrieval (langgenius#8134)
  fix: ollama text embedding 500 error (langgenius#8131)
  ...

# Conflicts:
#	api/configs/app_config.py
#	api/configs/feature/__init__.py
#	api/core/helper/code_executor/code_executor.py
#	api/services/conversation_service.py
#	web/yarn.lock
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants