Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an issue of keyword search feature in application log list #7816

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

realethanhsu
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

If there are multiple records in the Message table associated with the same Conversation, and some of these records contain target keywords, it can lead to duplicate Conversation records in the final query results. This results in wrong data counts and pagination issues. The revised code employs Conversation.id.in_(message_subquery) as a filter condition to ensure that only unique Conversations with related Messages are returned. This approach prevents duplicate Conversation records from appearing in the query results, thereby ensuring the accuracy of the log list and the proper functioning of the pagination feature.
Pasted Graphic
Pasted Graphic 1

Fixes #7815

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 29, 2024
@crazywoola
Copy link
Member

Please fix the errors in the CI.

@realethanhsu
Copy link
Contributor Author

OK, I will finish this work today.

@realethanhsu
Copy link
Contributor Author

@crazywoola done.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
@crazywoola crazywoola merged commit ea748b5 into langgenius:main Aug 30, 2024
6 checks passed
takatost added a commit that referenced this pull request Sep 4, 2024
@takatost
Copy link
Collaborator

takatost commented Sep 4, 2024

@realethanhsu This PR being modified to a full table scan statement, which resulted in a slow query, it could cause the database to go down.

The specific SQL that caused the full table scan is as follows:

...
conversations.id IN 
  (
    SELECT anon_2.conversation_id 
    FROM 
      (
	    SELECT messages.conversation_id AS conversation_id 
	    FROM messages 
	    WHERE messages.app_id = 'xxxx-xxxx-xxxx-xxxx-xxxx'::UUID
	    AND messages.query ILIKE '%abc%' OR messages.answer ILIKE '%abc%'
	  ) AS anon_2
  ) 
...

Due to the significant impact, we have rolled back for now.
Could you please check out the main branch again and optimize the SQL query based on it? Thank you very much.

@realethanhsu
Copy link
Contributor Author

@crazywoola Sure, I will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong pagination in application log list when using keyword search
3 participants