Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct image parameter passing in GLM-4v model API calls #2948

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Weishan-0
Copy link
Contributor

Description

  • Modify the 'type' field to use 'image_url' instead of 'image'.
  • Eliminate the Data URI scheme from a Base64-encoded image.

https://open.bigmodel.cn/dev/api#glm-4v

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement,including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 24, 2024
@crazywoola crazywoola requested a review from Yeuoly March 25, 2024 02:08
@crazywoola
Copy link
Member

Hello, please add my wechat: crazyphage I will invite you to the contributors' group.

@Yeuoly
Copy link
Collaborator

Yeuoly commented Mar 26, 2024

LGTM

@dosubot dosubot bot added the lgtm label Mar 26, 2024
@crazywoola crazywoola merged commit a676d43 into langgenius:main Mar 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants