-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update nginx and docker-compose files to support HTTPS. #2940
Conversation
Update docker-compose.yaml
Kennytian patch 1
@takatost Please review my PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend commenting on these lines, so that you can remove them when you need to, rather than having port 443 open by default in the first place
@crazywoola Thanks for your reply, I agree with you, and then will commenting on these lines right now. |
Co-authored-by: crazywoola <[email protected]>
Co-authored-by: crazywoola <[email protected]>
Description
Please include a summary of the changes and which issues are fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
How Has This Been Tested?
I have tested the code I submitted locally and everything works fine. Additionally, this change supports both HTTP and HTTPS requests. To enable HTTPS support, simply uncomment the code in the
docker/nginx/conf.d/default.conf
file and put the SSL certificate files in thedocker/nginx/ssl/
directory.Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests passed locally with my changes