Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect exception raised by api tool which leads to incorrect L… #2886

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

lancemao
Copy link
Contributor

fix incorrect exception raised by api tool which leads to incorrect LLM response

Description

The current code always raise ToolProviderCredentialValidationError exception event though credential is correct

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 19, 2024
@takatost takatost requested a review from Yeuoly March 19, 2024 07:35
@Yeuoly
Copy link
Collaborator

Yeuoly commented Mar 19, 2024

Hello, thanks for your contributions, it's a pretty good job to make sure API tool can raise correct Exceptions, but it seems that there is a CI error we should take a look at.

@bowenliang123
Copy link
Contributor

Nice, what a long-awaited fix to me.

Please run dev/reformat to autofix and make sure your Python code passes the style check.

@crazywoola crazywoola merged commit 53d4289 into langgenius:main Mar 19, 2024
7 checks passed
@dosubot dosubot bot added the lgtm label Mar 19, 2024
takatost pushed a commit that referenced this pull request Mar 19, 2024
@lancemao lancemao deleted the fix branch March 21, 2024 02:18
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants