Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk-overlap None check #2781

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chunk-overlap None check #2781

merged 1 commit into from
Mar 11, 2024

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Mar 11, 2024

Description

check chunk-overlap is None

Fixes # (issue)
#2772

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@JohnJyong JohnJyong requested a review from takatost March 11, 2024 07:21
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 11, 2024
@dosubot dosubot bot added the lgtm label Mar 11, 2024
@JohnJyong JohnJyong merged commit 6454e1d into main Mar 11, 2024
10 checks passed
@JohnJyong JohnJyong deleted the fix/chunk-overlap-none-check branch March 11, 2024 07:36
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants