Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: valid password on reset-password page #2753

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

yoogoc
Copy link
Contributor

@yoogoc yoogoc commented Mar 8, 2024

Description

web: if new_password is invalid, it should be stop request to api.
api: if new_password is invalid, it should be raised on the /account/password

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

old:

  1. click Account -> Settings -> Reset Password
  2. input a new simple password
  3. save, it is successful, but re-login is fail

new:

  1. click Account -> Settings -> Reset Password
  2. input a new simple password
  3. save, it is stop request

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 8, 2024
takatost
takatost previously approved these changes Mar 8, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm label Mar 8, 2024
@takatost takatost requested a review from JzoNgKVO March 8, 2024 07:19
JzoNgKVO
JzoNgKVO previously approved these changes Mar 8, 2024
@takatost
Copy link
Collaborator

takatost commented Mar 8, 2024

Hey there, the Lint test didn't pass. You need to run dev/reformat in the root directory before submitting.

@yoogoc
Copy link
Contributor Author

yoogoc commented Mar 8, 2024

Hey there, the Lint test didn't pass. You need to run dev/reformat in the root directory before submitting.

updated

@yoogoc yoogoc requested review from JzoNgKVO and takatost March 8, 2024 09:26
@takatost takatost merged commit bd26c93 into langgenius:main Mar 8, 2024
7 checks passed
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants