Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace message content type list to string when file_objs is empty .. #2745

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

vikeychen
Copy link
Contributor

…in get_history_prompt_messages

Description

When I was testing the chart generation tool with open-source model, I noticed that when there are files involved, although the files are not included in the prompt, the format of the prompt message is {"role":"assistant","content":[{"type":"text",...}]}, whereas the format for regular messages is {"role":"assistant","content":"str"}. my simulated OpenAI API backend does not support the former format. I understand this is an issue on the backend side, but maybe making this change would improve compatibility.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 7, 2024
@crazywoola crazywoola requested a review from takatost March 8, 2024 02:21
@takatost takatost requested review from Yeuoly and removed request for takatost March 8, 2024 07:21
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm label Mar 8, 2024
@takatost takatost merged commit 237bb85 into langgenius:main Mar 8, 2024
7 checks passed
@vikeychen vikeychen deleted the prompt_messages branch March 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants