Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/move tenant id into db #2341

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Feat/move tenant id into db #2341

merged 7 commits into from
Feb 2, 2024

Conversation

crazywoola
Copy link
Member

@crazywoola crazywoola commented Feb 1, 2024

This aims to remove the session usage in our code base, but to set this in jwt token is not that good, because we do not change that token very often.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 1, 2024
@crazywoola
Copy link
Member Author

@bowenliang123 @charli117 Please take a look at this if you have some spare time.

@charli117
Copy link
Contributor

charli117 commented Feb 1, 2024

@bowenliang123 @charli117 Please take a look at this if you have some spare time.

OK,functional verification no problem

@takatost
Copy link
Collaborator

takatost commented Feb 2, 2024

If we switch suddenly, will the data on the page still be in the context of the other workspace while the backend context has already switched to the workspace where the owner is?
What do you think about this?

takatost
takatost previously approved these changes Feb 2, 2024
@dosubot dosubot bot added the lgtm label Feb 2, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crazywoola crazywoola merged commit a8f23ed into main Feb 2, 2024
6 checks passed
@crazywoola crazywoola deleted the feat/move-tenant-id-to-jwt branch February 2, 2024 07:00
@crazywoola crazywoola restored the feat/move-tenant-id-to-jwt branch February 2, 2024 10:02
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants