Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support setting timezone in docker images #2091

Merged
merged 6 commits into from
Jan 19, 2024
Merged

support setting timezone in docker images #2091

merged 6 commits into from
Jan 19, 2024

Conversation

bowenliang123
Copy link
Contributor

  • install tzdata module in web docker image for timezone support
  • in web docker image, set the default TZ system env to UTC and be linked to /etc/localtime, referring Alpine docs: https://wiki.alpinelinux.org/wiki/Setting_the_timezone
  • in web docker image, set the default TZ system env to UTC

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 19, 2024
@bowenliang123 bowenliang123 changed the title support setting timezone in docker images of web and api support setting timezone in docker images via system env variables Jan 19, 2024
@bowenliang123 bowenliang123 changed the title support setting timezone in docker images via system env variables support setting timezone in docker images of web and api Jan 19, 2024
@bowenliang123 bowenliang123 changed the title support setting timezone in docker images of web and api support setting timezone in docker images Jan 19, 2024
takatost
takatost requested changes Jan 19, 2024
View reviewed changes
api/Dockerfile Outdated Show resolved Hide resolved
web/Dockerfile Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 19, 2024
takatost
takatost approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm label Jan 19, 2024
@takatost takatost merged commit 9ad7b65 into langgenius:main Jan 19, 2024
2 checks passed
@bowenliang123 bowenliang123 mentioned this pull request Jan 19, 2024
Merged
@bowenliang123 bowenliang123 deleted the web-timezone branch January 29, 2024 12:47
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
@bowenliang123
support setting timezone in docker images (langgenius#2091)
e07f3b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowenliang123 @takatost