Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extractor): temporary file #10543

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(extractor): temporary file #10543

merged 1 commit into from
Nov 11, 2024

Conversation

laipz8200
Copy link
Collaborator

@laipz8200 laipz8200 commented Nov 11, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Use non-deleting temporary files more effectively.
  • Simplify code by removing explicit file deletion.
  • Improve resource management and readability.

If delete is false, the value of delete_on_close is ignored.

refer https://docs.python.org/3.13/library/tempfile.html#tempfile.NamedTemporaryFile

partial revert #10407

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Use non-deleting temporary files more effectively.
- Simplify code by removing explicit file deletion.
- Improve resource management and readability.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@crazywoola crazywoola merged commit a1543b7 into main Nov 11, 2024
9 checks passed
@crazywoola crazywoola deleted the fix/temporary-file branch November 11, 2024 09:31
@laipz8200
Copy link
Collaborator Author

cc @wlrnet

AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants