Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): cleanup repeated cause exception in logging.exception replaced by helpful message #10425

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Nov 7, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 7, 2024
@bowenliang123 bowenliang123 changed the title chore(lint): cleanup redundant repated cause exception in logging.exception replaced by helpful message chore(lint): cleanup redundant cause exception in logging.exception replaced by helpful message Nov 7, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Nov 8, 2024

cc @crazywoola @laipz8200

@bowenliang123 bowenliang123 changed the title chore(lint): cleanup redundant cause exception in logging.exception replaced by helpful message chore(lint): cleanup repeated cause exception in logging.exception replaced by helpful message Nov 8, 2024
@bowenliang123 bowenliang123 force-pushed the ruff-try401 branch 3 times, most recently from 7a43b0e to e92d323 Compare November 11, 2024 12:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@laipz8200 laipz8200 merged commit 51db596 into langgenius:main Nov 15, 2024
9 checks passed
@bowenliang123 bowenliang123 deleted the ruff-try401 branch November 15, 2024 07:51
@bowenliang123
Copy link
Contributor Author

Thanks for the review and merging.
BTW, all the changes in this PR are made and checked manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants