Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The SSRF request timeout configuration item is added #10292

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

gubinjie
Copy link
Contributor

@gubinjie gubinjie commented Nov 5, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

The SSRF request timeout configuration item is added

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

  • Test A
  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 5, 2024
@gubinjie
Copy link
Contributor Author

gubinjie commented Nov 5, 2024

@BenjaminX why? Run Pytest / API Tests (3.10)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2024
@crazywoola crazywoola merged commit ce1f9d9 into langgenius:main Nov 6, 2024
6 checks passed
@laipz8200
Copy link
Member

Would you mind opening another PR to add those new environment variables to the .env.example file under the docker/ dir?

@gubinjie
Copy link
Contributor Author

Don't mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants