Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only pop graph if 'serialized' is not none #1336

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

only pop graph if 'serialized' is not none #1336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0782185
fix
isahers1 Dec 13, 2024
7e633b0
change
isahers1 Dec 13, 2024
1079b3e
will comment
isahers1 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/langsmith/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Client for interacting with the LangSmith API.

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

...........
WARNING: the benchmark result may be unstable
* the standard deviation (79.5 ms) is 12% of the mean (678 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_5_000_run_trees: Mean +- std dev: 678 ms +- 79 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (215 ms) is 15% of the mean (1.44 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_10_000_run_trees: Mean +- std dev: 1.44 sec +- 0.21 sec
...........
WARNING: the benchmark result may be unstable
* the standard deviation (170 ms) is 12% of the mean (1.36 sec)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_20_000_run_trees: Mean +- std dev: 1.36 sec +- 0.17 sec
...........
dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 687 us +- 4 us
...........
dumps_class_nested_py_leaf_50x100: Mean +- std dev: 25.0 ms +- 0.3 ms
...........
dumps_class_nested_py_leaf_100x200: Mean +- std dev: 104 ms +- 2 ms
...........
dumps_dataclass_nested_50x100: Mean +- std dev: 25.2 ms +- 0.2 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (15.9 ms) is 22% of the mean (70.8 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

dumps_pydantic_nested_50x100: Mean +- std dev: 70.8 ms +- 15.9 ms
...........
dumps_pydanticv1_nested_50x100: Mean +- std dev: 197 ms +- 3 ms

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------------+----------+------------------------+
| Benchmark                                     | main     | changes                |
+===============================================+==========+========================+
| dumps_pydanticv1_nested_50x100                | 217 ms   | 197 ms: 1.10x faster   |
+-----------------------------------------------+----------+------------------------+
| create_5_000_run_trees                        | 721 ms   | 678 ms: 1.06x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_branch_and_leaf_200x400 | 695 us   | 687 us: 1.01x faster   |
+-----------------------------------------------+----------+------------------------+
| create_20_000_run_trees                       | 1.36 sec | 1.36 sec: 1.00x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_dataclass_nested_50x100                 | 25.2 ms  | 25.2 ms: 1.00x slower  |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_100x200            | 103 ms   | 104 ms: 1.01x slower   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_50x100             | 24.8 ms  | 25.0 ms: 1.01x slower  |
+-----------------------------------------------+----------+------------------------+
| create_10_000_run_trees                       | 1.37 sec | 1.44 sec: 1.06x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_pydantic_nested_50x100                  | 64.9 ms  | 70.8 ms: 1.09x slower  |
+-----------------------------------------------+----------+------------------------+
| Geometric mean                                | (ref)    | 1.00x faster           |
+-----------------------------------------------+----------+------------------------+

Use the client to customize API keys / workspace ocnnections, SSl certs,
etc. for tracing.
Expand Down Expand Up @@ -1179,7 +1179,7 @@
):
# Drop completely
run_create.pop("serialized", None)
else:
elif not run_create.get("serialized"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops i inverted it - should remove the not - my fault

# Drop graph
run_create["serialized"].pop("graph", None)

Expand Down
Loading