feat: log wrap_openai runs with unified usage_metadata #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
commented
Oct 7, 2024
agola11
changed the title
agola11
commented
Oct 8, 2024
There was a problem hiding this comment.
These test files will be synced over to langsmith repo for test data
agola11
commented
Oct 8, 2024
hinthornw
reviewed
Oct 8, 2024
python/langsmith/wrappers/_openai.py
Outdated
| @@ -160,12 +167,59 @@ def _reduce_completions(all_chunks: List[Completion]) -> dict: | |||
| return d | |||
|
|
|||
|
|
|||
| def _create_usage_metadata(oai_token_usage: dict) -> UsageMetadata: | |||
| input_tokens = oai_token_usage.get("prompt_tokens", 0) | |||
| output_tokens = oai_token_usage.get("completion_tokens", 0) | |||
There was a problem hiding this comment.
would you ever get "None" as a value here? Maybe better to do "or 0" to avoid a None + None scenario?
hinthornw
reviewed
Oct 8, 2024
baskaryan
reviewed
Oct 8, 2024
| @@ -891,3 +891,64 @@ class PromptSortField(str, Enum): | |||
| """Last updated time.""" | |||
| num_likes = "num_likes" | |||
| """Number of likes.""" | |||
|
|
|||
|
|
|||
| class InputTokenDetails(TypedDict, total=False): | |||
There was a problem hiding this comment.
unrelated to this pr — wonder if langchain-core should import these from langsmith sdk now
nfcampos
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.