Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support correction when creating feedback with token #736

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

hinthornw
Copy link
Contributor

Closes #735

@eyurtsev
Copy link
Collaborator

eyurtsev commented Sep 2, 2024

Updated PR to remove all changes except for the bug fix itself. Was failing unit tests due to backwards compatible changes in langchain-core that were causing unit tests to fail (as those were essentially using snapshots)

@eyurtsev eyurtsev changed the title Support correction Support correction when creating feedback with token Sep 2, 2024
@eyurtsev eyurtsev merged commit 62e648a into main Sep 2, 2024
11 checks passed
@eyurtsev eyurtsev deleted the wfh/support_correction branch September 2, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"correction" field isn't passed from the "token_feedback" endpoint to the Langsmith "/feedback/tokens/" API
2 participants