Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped Feedback: Plumb through scoped feedback #568

Merged
merged 12 commits into from
Mar 28, 2024
Merged

Scoped Feedback: Plumb through scoped feedback #568

merged 12 commits into from
Mar 28, 2024

Conversation

eyurtsev
Copy link
Collaborator

After this PR most of the scaffolding code is in place to support scoped
feedback.

After this PR the remaining work to be done:

  1. Expose configuration in APIHandler / add_routes
  2. Determine how to support with the existing feedback endpoint (or change to a new endpoint)
  3. Surface in RemoteRunnable

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
@eyurtsev eyurtsev changed the title Plumb through scoped feedback Scoped Feedback: Plumb through scoped feedback Mar 28, 2024
@eyurtsev eyurtsev mentioned this pull request Mar 28, 2024
Open
4 tasks
@eyurtsev eyurtsev merged commit 04b9c95 into main Mar 28, 2024
11 checks passed
@eyurtsev eyurtsev deleted the eugene/add_feedback_link branch March 28, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 Awaiting requested review from jacoblee93

@jakerachleff jakerachleff Awaiting requested review from jakerachleff

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eyurtsev