Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct collection name for Milvus store to use underscores #793

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

dkarlovi
Copy link
Contributor

@dkarlovi dkarlovi commented Apr 14, 2023

Current name produces an error when using Milvus 2.3.0

Invalid collection name: goldel-escher-bach.  collection name can only contain numbers, letters and underscores

Current name produces an error when using Milvus 2.3.0

"Invalid collection name: goldel-escher-bach.  collection name can only contain numbers, letters and underscores"
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 14, 2023 0:11am

@nfcampos
Copy link
Collaborator

Thanks!

@nfcampos nfcampos merged commit 08824f7 into langchain-ai:main Apr 14, 2023
@dkarlovi dkarlovi deleted the patch-1 branch April 14, 2023 12:44
RohitMidha23 pushed a commit to RohitMidha23/langchainjs that referenced this pull request Apr 18, 2023
…gchain-ai#793)

* fix: correct collection name for Milvus store

Current name produces an error when using Milvus 2.3.0

"Invalid collection name: goldel-escher-bach.  collection name can only contain numbers, letters and underscores"

* Update milvus.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants