Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(community): ElasticVectorSearch: exclude metadata filters not working due changing to term instead of terms #6660

Conversation

LaurensTsestigh
Copy link
Contributor

The fix merged in #6536 broke our code due to the following error:

parsing_exception: [term] query does not support array of values

As we also need to allow an array, I made some changes to allow both term and terms.

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 29, 2024 8:28am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Aug 29, 2024 8:28am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Aug 29, 2024
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Sep 4, 2024

Hey sorry about this and the delay here - will test and have a look.

It might be nice to add an integration test here to prevent breakages in the future. I can look into it.

@jacoblee93 jacoblee93 changed the title ElasticVectorSearch: exclude metadata filters not working due changing to term instead of terms fix(community): ElasticVectorSearch: exclude metadata filters not working due changing to term instead of terms Sep 4, 2024
@jacoblee93
Copy link
Collaborator

Added in #6688 and will merge there. Thank you very much!

@jacoblee93
Copy link
Collaborator

Merged in #6688, thank you again!

@jacoblee93 jacoblee93 closed this Sep 4, 2024
@LaurensTsestigh
Copy link
Contributor Author

Hey sorry about this and the delay here - will test and have a look.

It might be nice to add an integration test here to prevent breakages in the future. I can look into it.

No problem at all, thanks for reviewing and merging!
Have a nice day

@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants