Add CI job (and make it green) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
commented
Feb 18, 2023
| @@ -11,6 +11,8 @@ const URL_BASE = | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| export type LoadValues = Record<string, any>; | |||
|
|
|||
| const URL_PATH_SEPARATOR = "/"; | |||
There was a problem hiding this comment.
These changes make it work on Windows. filesystem path separator is different on windows, but remote URL path separator isn't
nfcampos
commented
Feb 18, 2023
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| [*] | ||
| end_of_line = lf |
There was a problem hiding this comment.
For folks doing dev on windows to not clash with the linux/Mac defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadFromHubto work on Windows