Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[feat]: Add withListeners method to runnables/callbacks #3445

Closed
wants to merge 15 commits into from

Conversation

bracesproul
Copy link
Member

@bracesproul bracesproul commented Nov 29, 2023

  • Add withListeners to Runnable, RunnableEach, RunnableBinding.
  • Refactor logic inside RunnableBinding._mergeConfig to separate function (match PY).
  • Add extra check inside mergeConfigs to handle "callbacks".
  • Refactored constructor of CallbackManager to allow for passing in args that populate class properties.

(this branch is merged inside #3437)

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 6:06pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 1, 2023 6:06pm

@bracesproul bracesproul marked this pull request as ready for review November 30, 2023 01:04
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Nov 30, 2023
@bracesproul bracesproul changed the title adds withListeners method to runnables/callbacks core[feat]: Add withListeners method to runnables/callbacks Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants