Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null or undefined records causing error in Xata similarity search method #3425

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Fix null or undefined records causing error in Xata similarity search method #3425

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
689e571
fix: records null or undefined causing error in xata similarity searc…
codenameakshay Nov 28, 2023
a1e99e2
fix: remove unnecessary line change
codenameakshay Nov 28, 2023
e547efa
fix: bad type error
codenameakshay Nov 29, 2023
73bfe5a
Merge branch 'main' into codenameakshay/fix/xata-records-map-bug
codenameakshay Nov 29, 2023
faefd1c
Format
jacoblee93 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions langchain/src/vectorstores/xata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class XataVectorSearch<
);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
return records.map((record: any) => [
return records?.map((record) => [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this eslint rule if the any is removed.

new Document({
pageContent: record.content,
metadata: Object.fromEntries(
Expand All @@ -142,6 +142,6 @@ export class XataVectorSearch<
),
}),
record.xata.score,
]);
]) ?? [];
}
}