Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small core serialization issue #3386

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix small core serialization issue #3386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dfbd4f
Fix small core serialization issue
jacoblee93 Nov 23, 2023
8e5f99e
Bump
jacoblee93 Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langchain-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@langchain/core",
"version": "0.0.0",
"version": "0.0.1",
"description": "Core LangChain.js abstractions and schemas",
"type": "module",
"engines": {
Expand Down
2 changes: 2 additions & 0 deletions langchain-core/src/prompt_values.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export abstract class BasePromptValue extends Serializable {
export class StringPromptValue extends BasePromptValue {
lc_namespace = ["langchain_core", "prompt_values"];

lc_serializable = true;

value: string;

constructor(value: string) {
Expand Down
2 changes: 1 addition & 1 deletion langchain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,7 @@
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the PR! I noticed that the dependency for "@langchain/core" has been updated from "^0.0.0" to "^0.0.1". This comment is to flag the change for maintainers to review the dev dependencies.

"dependencies": {
"@langchain/anthropic": "^0.0.2",
"@langchain/core": "^0.0.0",
"@langchain/core": "^0.0.1",
"@langchain/openai": "^0.0.0",
"binary-extensions": "^2.2.0",
"expr-eval": "^2.0.2",
Expand Down
2 changes: 1 addition & 1 deletion libs/langchain-anthropic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"license": "MIT",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the PR! I noticed a change in the dependencies, specifically the "@langchain/core" dependency has been updated from "^0.0.0" to "^0.0.1". This comment is to flag the change for maintainers to review the devDependencies.

"dependencies": {
"@anthropic-ai/sdk": "^0.10.0",
"@langchain/core": "^0.0.0"
"@langchain/core": "^0.0.1"
},
"devDependencies": {
"@jest/globals": "^29.5.0",
Expand Down
2 changes: 1 addition & 1 deletion libs/langchain-openai/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"author": "LangChain",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the PR! This comment is just to flag the dependency change in the package.json file for maintainers to review. It seems to be a peer/dev/hard dependency change for "@langchain/core" from version 0.0.0 to 0.0.1.

"license": "MIT",
"dependencies": {
"@langchain/core": "^0.0.0",
"@langchain/core": "^0.0.1",
"js-tiktoken": "^1.0.7",
"openai": "^4.19.0",
"zod-to-json-schema": "3.20.3"
Expand Down
Loading