fix: query parameters are not passed correctly to WolframAlpha API (#…

…3502)

* fix: query parameters are not passed correctly to WolframAlpha API

* Lint + format

* Fix test

---------

Co-authored-by: jacoblee93 <[email protected]>

langchain/src/tools/tests/wolframalpha.test.ts

@@ -0,0 +1,47 @@
+import { jest, afterEach, beforeEach, describe, expect } from "@jest/globals";
+import { WolframAlphaTool } from "../wolframalpha.js";
+
+const MOCK_APP_ID = "[MOCK_APP_ID]";
+const QUERY_1 = "What is 2 + 2?";
+const MOCK_ANSWER = "[MOCK_ANSWER]";
+
+describe("wolfram alpha test suite", () => {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  let fetchMock: any;
+
+  beforeEach(() => {
+    fetchMock = jest.spyOn(global, "fetch").mockImplementation(
+      async () =>
+        ({
+          text: () => Promise.resolve(MOCK_ANSWER),
+        } as Response)
+    );
+  });
+
+  afterEach(() => {
+    fetchMock.mockRestore();
+  });
+
+  test("test query parameters passed correctly", async () => {
+    const wolframAlpha = new WolframAlphaTool({
+      appid: MOCK_APP_ID,
+    });
+    await wolframAlpha._call(QUERY_1);
+    const [url] = fetchMock.mock.calls[0];
+    const parsedUrl = new URL(url);
+    const params = new URLSearchParams(parsedUrl.search);
+
+    expect(fetchMock).toBeCalledTimes(1);
+    expect(params.get("appid")).toBe(MOCK_APP_ID);
+    expect(params.get("input")).toBe(QUERY_1);
+  });
+
+  test("test answer retrieved", async () => {
+    const wolframAlpha = new WolframAlphaTool({
+      appid: MOCK_APP_ID,
+    });
+
+    const answer = await wolframAlpha._call(QUERY_1);
+    expect(answer).toBe(MOCK_ANSWER);
+  });
+});

langchain/src/tools/wolframalpha.ts

@@ -31,7 +31,9 @@ export class WolframAlphaTool extends Tool {
   }
 
   async _call(query: string): Promise<string> {
-    const url = `https://www.wolframalpha.com/api/v1/llm-api?appid=${this.appid}&input=${query}`;
+    const url = `https://www.wolframalpha.com/api/v1/llm-api?appid=${
+      this.appid
+    }&input=${encodeURIComponent(query)}`;
     const res = await fetch(url);
 
     return res.text();