fix(community): ElasticVectorSearch: exclude metadata filters not wor…

…king due changing to term instead of terms (#6688) Co-authored-by: Laurens Tsestigh <[email protected]>
langchain-ai · Sep 4, 2024 · 2d57260 · 2d57260
1 parent 6febc0c
commit 2d57260
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/libs/langchain-community/src/vectorstores/elasticsearch.ts b/libs/langchain-community/src/vectorstores/elasticsearch.ts
@@ -343,10 +343,11 @@ export class ElasticVectorSearch extends VectorStore {
           },
         });
       } else if (condition.operator === "exclude") {
+        const toExclude = { [metadataField]: condition.value };
         must_not.push({
-          term: {
-            [metadataField]: condition.value,
-          },
+          ...(Array.isArray(condition.value)
+            ? { terms: toExclude }
+            : { term: toExclude }),
         });
       } else if (condition.operator === "or") {
         should.push({

diff --git a/libs/langchain-community/src/vectorstores/tests/elasticsearch.int.test.ts b/libs/langchain-community/src/vectorstores/tests/elasticsearch.int.test.ts
@@ -114,6 +114,14 @@ describe("ElasticVectorSearch", () => {
       },
     ]);
     expect(results2).toHaveLength(1);
+    const results3 = await store.similaritySearch("*", 11, [
+      {
+        field: "a",
+        value: [createdAt],
+        operator: "exclude",
+      },
+    ]);
+    expect(results3).toHaveLength(1);
   });
 
   test.skip("ElasticVectorSearch integration with text splitting metadata", async () => {