Return feedback #9629
Merged
Return feedback #9629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
baskaryan
reviewed
Aug 23, 2023
| @@ -62,13 +63,13 @@ class EvaluatorCallbackHandler(BaseTracer): | |||
| The LangSmith project name to be organize eval chain runs under. | |||
| """ | |||
|
|
|||
| name: str = "evaluator_callback_handler" | |||
There was a problem hiding this comment.
heh wasn't intentional
| except Exception as e: | ||
| logger.error( | ||
| f"Error evaluating run {run.id} with " | ||
| f"{evaluator.__class__.__name__}: {e}", | ||
| exc_info=True, | ||
| ) | ||
| raise e | ||
| example_id = str(run.reference_example_id) | ||
| self.logged_feedback.setdefault(example_id, []).append(feedback) |
There was a problem hiding this comment.
maybe noob q but why can't feedback just be returned
There was a problem hiding this comment.
the callbacks are all called via the run manager in the depths of the callstack so it would just be ignored sadly
hinthornw
force-pushed
the
wfh/return_feedback
branch
from
2b88733 to
f6dc4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the feedback values in an eval run result
Also made a helper method to display as a dataframe but it may be overkill