-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change JSONLoader content_key behavior #8075
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
is there any way to make this backwards compatible? |
I think a way to make it backward compatible would be to determine if the However, I think that even if temporary backward compatibility is ensured with this method, it will not be able to inevitable future specification complications, so I have submitted this pull request as a non-backward-compatible change. |
@kzk-maeda Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks! |
Description
Changed the value specified for
content_key
in JSONLoader from a single key to a value based on jq schema.Why
For json data like the following, specify
.data[].attributes.message
for page_content and.data[].attributes.id
or.data[].attributes.attributes. tags
, etc., thecontent_key
must also parse the json structure.sample json data
sample code
Dependencies
none
Tag maintainer
@rlancemartin, @eyurtsev
Twitter handle
kzk_maeda