Fix inconsistent behavior of CharacterTextSplitter
when changing keep_separator
#7263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep_separator
isTrue
the_split_text_with_regex()
method intext_splitter
uses regex to split, but whenkeep_separator
isFalse
it usesstr.split()
. This causes problems when the separator is a special regex character like.
or*
. This PR fixes that by usingre.split()
in both cases.CharacterTextSplitter
when changingkeep_separator
for special regex characters #7262