-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make so explicit class constructor is called in ElasticVectorSearch from_texts #6199
Make so explicit class constructor is called in ElasticVectorSearch from_texts #6199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well wouldnt this initizlize the wrong class entirely for knn then?
It would. Yeah. It seems like there is not a reasonable way to reuse ElasticVectorSearch.from_texts for ElasticKnnSearch with the implied semantics. Am I wrong? |
yeah seems that way. maybe worth splitting up classes even more? |
Someone is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Done. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Fixes #6198
ElasticKnnSearch.from_texts is actually ElasticVectorSearch.from_texts and throws because it calls ElasticKnnSearch constructor with the wrong arguments.
Now ElasticKnnSearch has its own from_texts, which constructs a proper ElasticKnnSearch.
Who can review?
@CodeDevNinja @dev2049