-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring PDF loaders: 02 PyMuPDF #29063
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Add file_path with PurePath Add CloudBlobLoader in __init__ Replace Dict/List to dict/list
039819c
to
3beda82
Compare
@eyurtsev I rebase the code with master ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great will take a look in the AM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two major comment, a few stylistic comments and some nits.
Let's tackle the two major comments:
- Define the standardized structure of metadata
- Create a dedicated ImageParser which is a blob parser
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
0d99673
to
3fe4ec5
Compare
4342991
to
760267b
Compare
fa3251b
to
023ba11
Compare
52e1a02
to
830e10d
Compare
fe4101b
to
a9065ee
Compare
yum is deprecated and replaced by dnf. |
a9065ee
to
0fe40a2
Compare
0fe40a2
to
2c4b1f6
Compare
2c4b1f6
to
a4587f0
Compare
libs/community/langchain_community/document_loaders/parsers/images.py
Outdated
Show resolved
Hide resolved
f2fea1f
to
74d3617
Compare
Refactoring PDF loaders step 2: "community: Refactoring PDF loaders to standardize approaches"
Description: Update PyMuPDFParser/Loader
Twitter handle: pprados
This is one part of a larger Pull Request (PR) that is too large to be submitted all at once.
This specific part focuses to prepare the update of all parsers.
For more details, see PR 28970.
@eyurtsev it's the continuation of PDFLoader modifications.