-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[minor]: FAISS Filter Function Enhancement with Advanced Query Operators #28207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases in test_faiss.py in total
FAISS filter: Merge optimizations and tests
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Nov 19, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
community
Related to langchain-community
Ɑ: vector store
Related to vector store module
labels
Nov 19, 2024
Co-Authored-By: RuofanChen03 <[email protected]> Co-Authored-By: Like Wang <[email protected]> Co-Authored-By: Shanni Li <[email protected]>
Co-Authored-By: RuofanChen03 <[email protected]> Co-Authored-By: Like Wang <[email protected]> Co-Authored-By: Shanni Li <[email protected]>
eyurtsev
changed the title
Community: FAISS Filter Function Enhancement with Advanced Query Operators
community[minor]: FAISS Filter Function Enhancement with Advanced Query Operators
Dec 11, 2024
eyurtsev
approved these changes
Dec 11, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Dec 11, 2024
@vincentzhang15 , @RuofanChen03, @LikeWang10067, @TANYAL77 -- thank you! Very nicely done PR! |
ccurme
added a commit
that referenced
this pull request
Jan 2, 2025
…Demonstration (#28938) ## Description This pull request updates the documentation for FAISS regarding filter construction, following the changes made in commit `df5008f`. ## Issue None. This is a follow-up PR for documentation of [#28207](#28207) ## Dependencies: None. --------- Co-authored-by: Chester Curme <[email protected]>
pprados
pushed a commit
to pprados/langchain
that referenced
this pull request
Jan 3, 2025
…Demonstration (langchain-ai#28938) ## Description This pull request updates the documentation for FAISS regarding filter construction, following the changes made in commit `df5008f`. ## Issue None. This is a follow-up PR for documentation of [langchain-ai#28207](langchain-ai#28207) ## Dependencies: None. --------- Co-authored-by: Chester Curme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
Related to langchain-community
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:XL
This PR changes 500-999 lines, ignoring generated files.
Ɑ: vector store
Related to vector store module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are submitting as a team of four for a project. Other team members are @RuofanChen03, @LikeWang10067, @TANYAL77.
This pull requests expands the filtering capabilities of the FAISS vectorstore by adding MongoDB-style query operators indicated as follows, while including comprehensive testing for the added functionality.
Issue
This closes #26379.
Sample Usage
Output