Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database connections for neo4j #27190

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix database connections for neo4j #27190

merged 2 commits into from
Oct 8, 2024

Conversation

tomasonjo
Copy link
Contributor

Fixes #27185

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 11:45pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Oct 8, 2024
This was referenced Oct 8, 2024
Closed
Open
Closed
efriis
efriis reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be a breaking change for folks on an older sdk version?

@efriis efriis self-assigned this Oct 8, 2024
@tomasonjo
Copy link
Contributor Author

Not a breaking change, rather a bug fix

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 8, 2024
@efriis efriis enabled auto-merge (squash) October 8, 2024 23:45
@efriis efriis merged commit 481bd25 into langchain-ai:master Oct 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neo4jGraph add_graph_documents not works while database specified, and still use the default database
2 participants
@tomasonjo @efriis