openai[patch]: add usage metadata details #27080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:L
eyurtsev
reviewed
Oct 3, 2024
| input_tokens=input_tokens, | ||
| output_tokens=output_tokens, | ||
| total_tokens=total_tokens, | ||
| input_token_details=InputTokenDetails( |
There was a problem hiding this comment.
Do you need InputTokenDetails here? Does it do a 2nd instantiation?
There was a problem hiding this comment.
for lint, could type ignore
| return ["reasoning_output", "cache_read_input"] | ||
|
|
||
| def invoke_with_cache_read_input(self, *, stream: bool = False) -> AIMessage: | ||
| with open(REPO_ROOT_DIR / "README.md", "r") as f: |
There was a problem hiding this comment.
Could we avoid loading a file here if ti's not necessary?
There was a problem hiding this comment.
having a >2k token string literal seems not great for readability
efriis
approved these changes
Oct 3, 2024
dosubot
bot
added
the
lgtm
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.