-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add various ruff rules #26836
core: Add various ruff rules #26836
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
30b57a4
to
540635a
Compare
@@ -291,9 +292,14 @@ async def _render_mermaid_using_pyppeteer( | |||
img_bytes = await page.screenshot({"fullPage": False}) | |||
await browser.close() | |||
|
|||
def write_to_file(path: str, bytes: bytes) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this from a ruff rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because we are in an async context so we can’t use blocking open()
and write()
directly (ruff rule ASYNC)
@cbornet looks good -- what fraction of these have corresponding auto-formatting if any? |
Auto-fix is mostly |
f04a6af
to
44566c4
Compare
44566c4
to
a838990
Compare
DJ - why do we need django lint rules? TID - nice! looks like we can enforce some of the import greps with this instead of the scripts |
Adds