Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Fix tool_calls parsing when streaming from DeepInfra #26813

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

thunze
Copy link
Contributor

@thunze thunze commented Sep 24, 2024

  • Description: This PR fixes the response parsing logic for ChatDeepInfra, more specifially _convert_delta_to_message_chunk(), which is invoked when streaming via ChatDeepInfra.
  • Issue: Streaming from DeepInfra via ChatDeepInfra is currently broken because the response parsing logic doesn't handle that tool_calls can be None. (There is no GitHub issue for this problem yet.)
  • Dependencies:
  • Twitter handle:

Keeping this here as a reminder:

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2024
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 1:45pm

@dosubot dosubot bot added community Related to langchain-community 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 24, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 24, 2024
@ccurme ccurme enabled auto-merge (squash) September 24, 2024 13:45
@ccurme ccurme merged commit 2b83c7c into langchain-ai:master Sep 24, 2024
31 checks passed
@thunze thunze deleted the deepinfra-parsing-fix branch September 24, 2024 13:49
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
…fra (langchain-ai#26813)

- **Description:** This PR fixes the response parsing logic for
`ChatDeepInfra`, more specifially `_convert_delta_to_message_chunk()`,
which is invoked when streaming via `ChatDeepInfra`.
- **Issue:** Streaming from DeepInfra via `ChatDeepInfra` is currently
broken because the response parsing logic doesn't handle that
`tool_calls` can be `None`. (There is no GitHub issue for this problem
yet.)
- **Dependencies:** –
- **Twitter handle:** –

Keeping this here as a reminder:
> If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants