Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstructured[patch]: support loading URLs #26670

Merged
merged 4 commits into from
Sep 19, 2024
Merged

unstructured[patch]: support loading URLs #26670

merged 4 commits into from
Sep 19, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Sep 19, 2024

unstructured.partition.auto.partition supports a url kwarg, but url in UnstructuredLoader.__init__ is reserved for the server URL. Here we add a web_url kwarg that is passed to the partition kwargs:

self.unstructured_kwargs["url"] = web_url

@efriis efriis added the partner label Sep 19, 2024
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 6:06pm

@efriis efriis self-assigned this Sep 19, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: doc loader Related to document loader module (not documentation) labels Sep 19, 2024
@Coniferish
Copy link
Contributor

LGTM. Only comment would be to potentially add an example to docs/docs/integrations/document_loaders/unstructured_file.ipynb, but I don't think that's a blocker necessarily.

@ccurme
Copy link
Collaborator Author

ccurme commented Sep 19, 2024

LGTM. Only comment would be to potentially add an example to docs/docs/integrations/document_loaders/unstructured_file.ipynb, but I don't think that's a blocker necessarily.

Thanks, added!

@efriis efriis merged commit eef18de into master Sep 19, 2024
21 checks passed
@efriis efriis deleted the cc/unstructured_url branch September 19, 2024 18:40
Coniferish added a commit to Coniferish/langchain that referenced this pull request Sep 24, 2024
efriis pushed a commit that referenced this pull request Sep 24, 2024
**Description:** update package version to support loading URLs #26670
**Issue:**  #26697
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
`unstructured.partition.auto.partition` supports a `url` kwarg, but
`url` in `UnstructuredLoader.__init__` is reserved for the server URL.
Here we add a `web_url` kwarg that is passed to the partition kwargs:
```python
self.unstructured_kwargs["url"] = web_url
```
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
**Description:** update package version to support loading URLs langchain-ai#26670
**Issue:**  langchain-ai#26697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) partner size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants