-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[community] Add timeout control and retry for UC tool execution #26645
Conversation
Signed-off-by: serena-ruan <[email protected]>
Signed-off-by: serena-ruan <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: serena-ruan <[email protected]>
@harupy Could you stamp this PR as well as you reviewed my last one :D Thanks! |
libs/community/langchain_community/tools/databricks/_execution.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/tools/databricks/_execution.py
Outdated
Show resolved
Hide resolved
Signed-off-by: serena-ruan <[email protected]>
converting to draft - let me know when it's ready for a review on the langchain side! As I've mentioned on a few other PRs, it would make sense to migrate the UC tools to the langchain-databricks repo. |
Thanks, we'll have some new implementation for langchain UC tools support, so want to keep the old one here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@efriis Hey Erick! :) This one's ready for your review. Thanks! |
Hi @efriis Could we merge this to catch the next release? Thanks! |
Hi @baskaryan Could you help merge this PR? Thanks! |
Sorry for the delay! |
Add timeout at client side for UCFunctionToolkit and add retry logic.
Users could specify environment variable
UC_TOOL_CLIENT_EXECUTION_TIMEOUT
to increase the timeout value for retrying to get the execution response if the status is pending. Default timeout value is 120s.docs/docs/integrations
directory.Tested in Databricks:
make format
,make lint
andmake test
from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.