core[patch]: Fix utils.json_schema.dereference_refs (#24335 KeyError: 400 in JSON schema processing) #24337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
Ɑ: core
- Modify `_retrieve_ref` function in `json_schema.py` to correctly handle both integer and string components. - Checks if `component` is a digit and if `int(component)` exists in the schema. - If `int(component)` does not exist, falls back to using `component` as a string key. - Ensures the OpenAPI specification is fully interpreted and the agent executes without errors.
eunhye1kim
force-pushed
the
fix_keyerror_400
branch
from
0edc5c4 to
573f4c0
Compare
dosubot
bot
added
size:M
- Add a new test `test_dereference_refs_string_ref` to ensure that string keys are handled properly in JSON schema references. - Adjust the `test_dereference_refs_missing_ref` to reflect the new behavior of `_retrieve_ref`. - Ensure that JSON schema processing can handle string keys without raising unnecessary KeyErrors.
eunhye1kim
force-pushed
the
fix_keyerror_400
branch
from
6bfa043 to
1b98a3d
Compare
- Modify `_retrieve_ref` function to ensure string keys are handled correctly and not incorrectly converted to integers. - Adjust test cases to ensure correct behavior for both integer and string keys.
eunhye1kim
force-pushed
the
fix_keyerror_400
branch
from
636588e to
388fbbe
Compare
|
Deployment failed with the following error: |
eunhye1kim
force-pushed
the
fix_keyerror_400
branch
from
ab77815 to
0b60c54
Compare
…JSON schema utility - Deleted logic in `_retrieve_ref` function that handled broken references by returning the original schema. - Adjusted the test `test_dereference_refs_missing_ref` to expect a `KeyError` for broken references.
eunhye1kim
force-pushed
the
fix_keyerror_400
branch
from
0b60c54 to
c65f09a
Compare
eunhye1kim
commented
Jul 19, 2024
| @@ -18,8 +18,7 @@ def _retrieve_ref(path: str, schema: dict) -> dict: | |||
| elif component.isdigit() and int(component) in out: | |||
| out = out[int(component)] | |||
| else: | |||
| # Returning the original schema or a default value if the key is not found | |||
There was a problem hiding this comment.
This code was added to ensure that the agent runs even if there is a problem with the swagger provided by an external solution. We decided that it was right to remove these reference errors through preprocessing logic before the user applied swagger to the agent, so in this case, we modified the code so that a ValueError was raised and also restored the test code.
dosubot
bot
added
the
lgtm
eyurtsev
changed the title
eyurtsev
changed the title
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
… KeyError: 400 in JSON schema processing) (langchain-ai#24337) Description: This PR fixes a KeyError: 400 that occurs in the JSON schema processing within the reduce_openapi_spec function. The _retrieve_ref function in json_schema.py was modified to handle missing components gracefully by continuing to the next component if the current one is not found. This ensures that the OpenAPI specification is fully interpreted and the agent executes without errors. Issue: Fixes issue langchain-ai#24335 Dependencies: No additional dependencies are required for this change. Twitter handle: @lunara_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a KeyError: 400 that occurs in the JSON schema processing within the reduce_openapi_spec function. The _retrieve_ref function in json_schema.py was modified to handle missing components gracefully by continuing to the next component if the current one is not found. This ensures that the OpenAPI specification is fully interpreted and the agent executes without errors.
Issue:
Fixes issue #24335
Dependencies:
No additional dependencies are required for this change.
Twitter handle:
@lunara_x