Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community[minor]: Added checksum in while send data to pebblo-cloud #23968

Merged
merged 13 commits into from
Jul 19, 2024

Conversation

dristysrivastava
Copy link
Contributor

@dristysrivastava dristysrivastava commented Jul 8, 2024

  • Description:
    - Updated checksum in doc metadata
    - Sending checksum and removing actual content, while sending data to pebblo-cloud if classifier-location is pebblo-cloud in /loader/doc API
    - Adding pb_id i.e. pebblo id to doc metadata
    - Refactoring as needed.
    - Sending content-checksum and removing actual content, while sending data to pebblo-cloud if classifier-location is pebblo-cloud in prmopt API
  • Issue: NA
  • Dependencies: NA
  • Tests: Updated
  • Docs NA

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 4:27am

@dristysrivastava dristysrivastava changed the title Adding checksum Community: Added checksum in while send data to pebblo-cloud Jul 8, 2024
@dristysrivastava dristysrivastava marked this pull request as ready for review July 9, 2024 04:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 9, 2024
@dristysrivastava
Copy link
Contributor Author

@srics @Raj725 Please review

@srics
Copy link
Contributor

srics commented Jul 9, 2024

@srics @Raj725 Please review

LGTM

Copy link
Contributor

@srics srics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dristysrivastava
Copy link
Contributor Author

@eyurtsev Please review

@eyurtsev eyurtsev self-assigned this Jul 12, 2024
@srics
Copy link
Contributor

srics commented Jul 18, 2024

@eyurtsev @hwchase17 Can you pls help to review & land this PR? A significantly big enterprise user is waiting for this update. It is reviewed and signed off by pebblo maintainers.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 19, 2024
@eyurtsev eyurtsev changed the title Community: Added checksum in while send data to pebblo-cloud Community[minor]: Added checksum in while send data to pebblo-cloud Jul 19, 2024
@eyurtsev eyurtsev merged commit 020cc1c into langchain-ai:master Jul 19, 2024
43 checks passed
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
…angchain-ai#23968)

- **Description:** 
            - Updated checksum in doc metadata
- Sending checksum and removing actual content, while sending data to
`pebblo-cloud` if `classifier-location `is `pebblo-cloud` in
`/loader/doc` API
            - Adding `pb_id` i.e. pebblo id to doc metadata
            - Refactoring as needed.
- Sending `content-checksum` and removing actual content, while sending
data to `pebblo-cloud` if `classifier-location `is `pebblo-cloud` in
`prmopt` API
- **Issue:** NA
- **Dependencies:** NA
- **Tests:** Updated
- **Docs** NA

---------

Co-authored-by: dristy.cd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants