partners: support reading HuggingFace params from env #23309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
1 task
|
@efriis Please review and merge. |
eyurtsev
approved these changes
Jul 2, 2024
| @@ -46,11 +46,15 @@ class Config: | |||
|
|
|||
| extra = Extra.forbid | |||
|
|
|||
| @root_validator() | |||
| @root_validator(pre=False, skip_on_failure=True) | |||
There was a problem hiding this comment.
This should be pre=True based on the logic below -- all of it can be done as pre-init logic
Just requires re-writing values['model'] to values.get('model')
There was a problem hiding this comment.
Merging as is, but if you can please re-write this with pre=True
dosubot
bot
added
the
lgtm
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue: #22448 #22819