Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partners: add lint docstrings for chroma module #23249

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Zizo-Vi
Copy link
Contributor

@Zizo-Vi Zizo-Vi commented Jun 21, 2024

Description: add lint docstrings for chroma module
Issue: the issue #23188 @baskaryan

test: ruff check passed.

image

@efriis efriis added the partner label Jun 21, 2024
@efriis efriis self-assigned this Jun 21, 2024
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 7:47pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🔌: chroma Primarily related to ChromaDB integrations labels Jun 21, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 21, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) June 21, 2024 14:06
@Zizo-Vi
Copy link
Contributor Author

Zizo-Vi commented Jun 21, 2024

Hi @efriis This pr merged failed in CI process. According the CI failure log, this failure caused by another bug #9637 ?
pydantic/pydantic#9637

image

@eyurtsev eyurtsev merged commit f9aea3d into langchain-ai:master Jun 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌: chroma Primarily related to ChromaDB integrations lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants