Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate NVIDIAEmbeddings.embed_documents input type is list[str] #9

Merged
merged 1 commit into from
Mar 25, 2024
Merged

validate NVIDIAEmbeddings.embed_documents input type is list[str] #9

merged 1 commit into from
Mar 25, 2024

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented Mar 23, 2024

resolves #8

@mattf mattf requested a review from VKudlay March 23, 2024 13:23
@mattf mattf self-assigned this Mar 23, 2024
VKudlay
VKudlay approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@VKudlay VKudlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mattf mattf merged commit 5ba62a9 into main Mar 25, 2024
12 checks passed
@mattf mattf deleted the mattf/issue-8 branch March 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VKudlay VKudlay VKudlay approved these changes

Assignees

@mattf mattf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NVIDIAEmbeddings.embed_documents accepts any subscriptable, including a single string
2 participants
@mattf @VKudlay