Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pydantic v2 and v1 for with_structured_output #84

Merged
merged 2 commits into from
Aug 7, 2024
Merged

support pydantic v2 and v1 for with_structured_output #84

merged 2 commits into from
Aug 7, 2024

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented Aug 6, 2024

with_structured_output should accept types built from langchain_core.pydantic_v1 + pydantic.v1 + pydantic

previously only langchain_core.pydantic_v1 types were supported.

@mattf mattf self-assigned this Aug 6, 2024
@mattf mattf requested a review from raspawar August 6, 2024 16:08
raspawar
raspawar approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@raspawar raspawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed test case and it makes sense to me!

@mattf mattf merged commit e13519e into main Aug 7, 2024
12 checks passed
@mattf mattf deleted the mattf/align-pydantic-support branch August 7, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raspawar raspawar raspawar approved these changes

Assignees

@mattf mattf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattf @raspawar