-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client rejects incompatible models #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspawar
commented
Jul 25, 2024
libs/ai-endpoints/tests/integration_tests/test_register_model.py
Outdated
Show resolved
Hide resolved
mattf
reviewed
Jul 25, 2024
libs/ai-endpoints/tests/integration_tests/test_register_model.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of the connectors, I can select from many modals and want to be alerted early if a model is not compatible with my use case.
Example test, w/ public_class of ChatNVIDIA, NVIDIAEmbeddings, NVIDIARerank for LangChain -
{{ invalid = select known model that does not work with public_class, e.g. NV-Embed-QA and ChatNVIDIA
with pytest.raises(ValueError) as e:
public_class(model=invalid, nvidia_api_key="a-bogus-key")
assert "not compatible" in str(e.value)
}}
@sumitkbh