Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client rejects incompatible models #81

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Conversation

raspawar
Copy link
Collaborator

@raspawar raspawar commented Jul 25, 2024

As a user of the connectors, I can select from many modals and want to be alerted early if a model is not compatible with my use case.

Example test, w/ public_class of ChatNVIDIA, NVIDIAEmbeddings, NVIDIARerank for LangChain -

{{ invalid = select known model that does not work with public_class, e.g. NV-Embed-QA and ChatNVIDIA
with pytest.raises(ValueError) as e:
public_class(model=invalid, nvidia_api_key="a-bogus-key")
assert "not compatible" in str(e.value)
}}

@sumitkbh

@raspawar raspawar requested review from mattf and dglogo July 25, 2024 13:38
@mattf mattf merged commit 58f4156 into main Jul 31, 2024
12 checks passed
@mattf mattf deleted the raspawar/reject_invalid_models branch July 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants