Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strict support #104

Merged
merged 1 commit into from
Sep 23, 2024
Merged

add strict support #104

merged 1 commit into from
Sep 23, 2024

Conversation

mattf
Copy link
Collaborator

@mattf mattf commented Sep 20, 2024

NIM tool calling and structured output is always in strict mode. this change primarily informs users.

bind_tools -

  • strict is not part of default signature, it is a langchain-openai extension
  • if user passes strict and it is not True, raise a warning

with_structured_output -

  • strict is not part of default signature, it is a langchain-openai extension
  • if user passes strict and it is not True, raise a warning

NIM tool calling and structured output has always been in strict mode.

this change primarily informs users.
@mattf mattf requested a review from dglogo September 20, 2024 16:31
@mattf mattf self-assigned this Sep 20, 2024
@mattf mattf merged commit fc17dce into dev-v0.3 Sep 23, 2024
12 checks passed
@mattf mattf deleted the mattf/add-strict-support branch September 23, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant