remove deprecated model_type param (embedding) #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIDIAEmbeddings
' constructor accepts amodel_type
parameter with value of either"query"
or"passage"
using it changes the behavior of the standard
embed_query
andembed_documents
methods.for example, setting
model_type="passage"
and callingembed_query
results in using the same behavior as not settingmodel_type
and callingembed_passage
.this parameter is confusing to users and has been removed.
users should use
embed_query
when embedding queries andembed_passage
when embedding passages.if you would like to batch embed queries, please raise a feature request.
note: the query / passage distinction is only important for asymmetric embedding models